Skip to content

CI: Add maven wrapper and extend pre-commit hooks - #148

Merged
maltesander merged 3 commits into
stackabletech:mainfrom
Saul-STFC:ci/prek-and-maven-wrapper
Sep 2, 2026
Merged

CI: Add maven wrapper and extend pre-commit hooks #148
maltesander merged 3 commits into
stackabletech:mainfrom
Saul-STFC:ci/prek-and-maven-wrapper

Conversation

@Saul-STFC

Copy link
Copy Markdown
Contributor

This pr adds the maven wrapper to this repo, extends pre-commit hooks (matching other repos) and yamllint/markdownlint configs to match other repos + precommit linting (and fixing those issues)

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Documentation added or updated
  • Changelog updated

Acceptance

  • Proper release label has been added

…wnlint configs to match other repos + precommit linting
@Techassi Techassi moved this to Development: Waiting for Review in Stackable Engineering Aug 26, 2026
@Saul-STFC

Copy link
Copy Markdown
Contributor Author

@NickLarsenNZ @Techassi

@maltesander
maltesander self-requested a review September 1, 2026 14:59
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 1, 2026

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, LGTM otherwise.

Comment thread .github/pull_request_template.md Outdated
Co-authored-by: maltesander <malte.sander.it@gmail.com>

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maltesander
maltesander added this pull request to the merge queue Sep 2, 2026
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Sep 2, 2026
Merged via the queue into stackabletech:main with commit cb566cb Sep 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

3 participants